ScorePriority: fixed error message about invalid CUSIP length.#5563
Merged
buchen merged 1 commit intoportfolio-performance:masterfrom Mar 13, 2026
Merged
ScorePriority: fixed error message about invalid CUSIP length.#5563buchen merged 1 commit intoportfolio-performance:masterfrom
buchen merged 1 commit intoportfolio-performance:masterfrom
Conversation
1.) Corrected placeholder value for error message 2.) Do what the comment says and reject all lengths other than 9 3.) Fixed typo in comment. It is questionable to match CUSIPS with "(?<wkn>.*)" btw. Particularly as the dot also matches whitespace that later has to be dropped with trim() again. \w would be better but without more test cases we have to guess whether it needs to be surrounded with \s.
Contributor
Author
|
Fwiw: I do not have an account with ScorePriority. I merely ran across this check as part of the review for possible uses of SkippedItem (#5517). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.) Corrected placeholder value for error message
2.) Do what the comment says and reject all lengths other than 9
3.) Fixed typo in comment.
It is questionable to match CUSIPS with "(?.*)" btw. Particularly as the dot also matches whitespace that later has to be dropped with trim() again. \w would be better but without more test cases we have to guess whether it needs to be surrounded with \s.
PS: 1-2 more pull requests for similar checks will follow.