chore(outputs): adapt to new metadata specification #8651
+102
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
output/csv
|
✅ All necessary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8651 +/- ##
==========================================
- Coverage 75.75% 75.60% -0.15%
==========================================
Files 72 72
Lines 4851 4928 +77
==========================================
+ Hits 3675 3726 +51
- Misses 1176 1202 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jfagoagas
requested changes
Sep 5, 2025
Comment on lines
+81
to
+83
| finding_dict["ADDITIONAL_URLS"] = unroll_list( | ||
| finding.metadata.AdditionalURLs | ||
| ) |
There was a problem hiding this comment.
This needs to be the very last column, not to break automations reading CSV columns.
| @@ -163,6 +159,7 @@ def transform(self, findings: List[Finding]) -> None: | |||
| "categories": finding.metadata.Categories, | |||
| "depends_on": finding.metadata.DependsOn, | |||
| "related_to": finding.metadata.RelatedTo, | |||
| "additional_urls": finding.metadata.AdditionalURLs, | |||
There was a problem hiding this comment.
Review if the OCSF documentation needs to be updated too.
| @@ -14,6 +14,7 @@ All notable changes to the **Prowler SDK** are documented in this file. | |||
| - `--excluded-checks-file` flag [(#8301)](https://github.com/prowler-cloud/prowler/pull/8301) | |||
|
|
|||
| ### Changed | |||
| - Outputs content for new Metadata fields [(#8651)](https://github.com/prowler-cloud/prowler/pull/8651) | |||
There was a problem hiding this comment.
I'd add a new line in Added saying: "Support for AdditionalURLs in outputs"
| @@ -36,6 +36,7 @@ def generate_finding_output( | |||
| depends_on: list[str] = ["test-dependency"], | |||
| related_to: list[str] = ["test-related-to"], | |||
| notes: str = "test-notes", | |||
| additional_urls: list[str] = ["test-url"], | |||
There was a problem hiding this comment.
Add a valid URL, is better then to test and validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some changes were needed to match new metadata specification while preserving compatibility with old metadata and output formats.
Description
CSV
OCSF
HTML
ASFF
Steps to review
Execute 2 scans with all output formats (one with old metadata and other with new metadata) and ensure all are generated as expected.
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.