-
Notifications
You must be signed in to change notification settings - Fork 9
Candidate model #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Candidate model #11
Conversation
class DemoCandidateModel(BaseCandidateModel): | ||
def __init__(self): | ||
super().__init__() | ||
# init simple article data data process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thx for adding comment
# init | ||
self.title_list = title_list | ||
|
||
# word segmentation | ||
self.corpus_ws = self.word_segmentation(corpus=corpus, batch_size=batch_size) | ||
|
||
# lauch bm25 moidel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto, nice!
|
||
|
||
|
||
user_features = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think if we put them into fixtures
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can create any folder if you want
# demo data | ||
from organic_data import user_features, article_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
Fixes #[include a number of issue this PR is fixing].
Summary of changes proposed in this Pull Request:
PR checklist: