Skip to content

Conversation

hsuchengmath
Copy link

Fixes #[include a number of issue this PR is fixing].

Summary of changes proposed in this Pull Request:

PR checklist:

  • Updated relevant documentation
  • Updated CHANGELOG.md
  • Added tests for my change

Comment on lines +18 to +21
class DemoCandidateModel(BaseCandidateModel):
def __init__(self):
super().__init__()
# init simple article data data process
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx for adding comment

Comment on lines +14 to +20
# init
self.title_list = title_list

# word segmentation
self.corpus_ws = self.word_segmentation(corpus=corpus, batch_size=batch_size)

# lauch bm25 moidel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, nice!




user_features = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think if we put them into fixtures folder?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can create any folder if you want

Comment on lines +8 to +9
# demo data
from organic_data import user_features, article_data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good idea and maybe you can share these fixtures with other DS.
c.c. hane1818 PuChenTW

Copy link
Collaborator

@david30907d david30907d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants