<feat/recommendation> Implement a simple ranking model #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david30907d
reviewed
Mar 19, 2022
| from recommendation_system.ranking_layer.base import BaseRankingModel | ||
|
|
||
| class SimpleRankingModel(BaseRankingModel): | ||
| def __init__(self) -> None: |
There was a problem hiding this comment.
thx for annotating mypy typing!
david30907d
reviewed
Mar 19, 2022
| "ranking_model": "demo", | ||
| "ranking_model": "simple", |
There was a problem hiding this comment.
nice! we have ranking right now~
david30907d
reviewed
Mar 19, 2022
Comment on lines
+10
to
+12
| def rank(self, user_features: Dict, candidates: List[List[Dict]], top_k: int) -> List[Dict]: | ||
| candidates = self.process_data(candidates=candidates) | ||
| rankings = self.calc_candidate_score(candidates=candidates) |
david30907d
reviewed
Mar 19, 2022
| def get_item(self, item): | ||
| return deepcopy(self._items_mapping[item]) | ||
|
|
||
| def calc_candidate_score(self, candidates): |
There was a problem hiding this comment.
Suggested change
| def calc_candidate_score(self, candidates): | |
| def _calc_candidate_score(self, candidates): |
david30907d
reviewed
Mar 19, 2022
|
|
||
| return sorted(candidate_ranking.items(), key=lambda d: d[1], reverse=True) | ||
|
|
||
| def process_data(self, candidates: List[List[Dict]]) -> List[List[Tuple]]: |
There was a problem hiding this comment.
Suggested change
| def process_data(self, candidates: List[List[Dict]]) -> List[List[Tuple]]: | |
| def _process_data(self, candidates: List[List[Dict]]) -> List[List[Tuple]]: |
david30907d
reviewed
Mar 19, 2022
| return sorted(candidate_ranking.items(), key=lambda d: d[1], reverse=True) | ||
|
|
||
| def process_data(self, candidates: List[List[Dict]]) -> List[List[Tuple]]: | ||
| items_mapping = {} |
There was a problem hiding this comment.
Suggested change
| items_mapping = {} | |
| items_mapping = defaultdict(dict) |
There was a problem hiding this comment.
also, would you add typing for items_mapping? seems to me it's the key data structure of your algorithm. Might be worth annotating~
david30907d
reviewed
Mar 19, 2022
| items_mapping = {} | ||
| new_candidates = [] | ||
|
|
||
| for ranker in candidates: |
There was a problem hiding this comment.
why ranker is in candidates?
I'm not sure if I understand what does this ranker stand for 😅
david30907d
reviewed
Mar 19, 2022
Comment on lines
+16
to
+17
| new_item = self.get_item(item) | ||
| new_item['score'] = score |
There was a problem hiding this comment.
if you'd calculated score in calc_candiate_score func, then maybe you can return item along with score field right? thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[include a number of issue this PR is fixing].
Summary of changes proposed in this Pull Request:
PR checklist: