Skip to content

feat: 2025 schedule page #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 14, 2025

Conversation

neolooong
Copy link
Contributor

Types of changes

  • New feature
  • Refactoring

Description

  1. 先把時間表的頁面調整成 mock data 可以正常顯示,等之後確定資料是什麼,再做調整。
  2. 針對 components 做了重構,因為感覺 components 拆分地不太好。像是:
    1. 同時有單數與複數的 component (ScheduleDayTabs/ScheduleDayTab, ScheduleRooms/ScheduleRoom)
    2. 有些 component 裡面就只有 CSS,沒有 JS,HTML 部分也很單調。
    3. 處理不同螢幕寬度的 JS 通通集中在 pages/conference/Schedule.vue,但相關的 CSS 卻四散在各個 components。
  3. 移除 mapState

Related Issue

#626

Copy link

netlify bot commented May 17, 2025

👷 Deploy request for classy-granita-bc2b5a pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3d8ec06

Copy link

netlify bot commented May 17, 2025

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 3d8ec06
🔍 Latest deploy log https://app.netlify.com/projects/zesty-gnome-f04144/deploys/687242ed1798fa0008351532
😎 Deploy Preview https://deploy-preview-628--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wanyewei wanyewei requested a review from Ritabear May 22, 2025 15:10
@Ritabear Ritabear requested a review from rudd6617 May 27, 2025 13:31
@Ritabear
Copy link
Collaborator

Ritabear commented Jun 1, 2025

neo~ 想問問你的mock data能傳給我嗎? 因為我現在開有錯誤
以及 store/index.js showSchedulePage也要打開

@neolooong neolooong force-pushed the feature/schedule-ui-with-refactor branch from b1fd403 to 0be67be Compare July 9, 2025 13:20
@neolooong neolooong marked this pull request as ready for review July 10, 2025 12:49
@neolooong neolooong force-pushed the feature/schedule-ui-with-refactor branch from 0be67be to 3d8ec06 Compare July 12, 2025 11:11
Copy link
Collaborator

@Ritabear Ritabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ritabear Ritabear merged commit 086473c into pycontw:main Jul 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants