PEP 679: Modify proposal and improve sections #4575
+224
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Sep 4, 2025
peps/pep-0679.rst
Outdated
Comment on lines
104
to
105
| assert_stmt ::= "assert" expression [',' expression] | ||
| | "assert" '(' expression [',' expression] [','] ')' |
There was a problem hiding this comment.
Doesn't the parenthesized version need to go first?
There was a problem hiding this comment.
I need to redo this section to adapt to the PEG parser
There was a problem hiding this comment.
I made some changes in the last commit.
| parentheses. The lookahead is needed so statements like ``assert (a, b) <= c, | ||
| "something"`` are still parsed correctly and to prevent the parser to eagerly | ||
| capture the tuple as the full statement. | ||
| Implementation Notes |
There was a problem hiding this comment.
The specification now calls for a grammar change, so “Implementing in the compiler” can go to Rejected ideas.
There was a problem hiding this comment.
I think it is not, the compiler section notes that in 3.18 (no more warning), using the specified grammar,
the implementation can be moved to the parser level
Giving us the proper AST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4575.org.readthedocs.build/