Skip to content

Squash revision history and remove resolved issue #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

EwanC
Copy link
Collaborator

@EwanC EwanC commented Mar 23, 2023

For our first beta release we should just be at revision 1, then later updates to a merged spec can bump this when we feel is appropriate.

This patch also removes the issue about whether executable graph update is valuable to users, as we've found evidence of the equivalent CUDA functionality in pytorch, tensorflow, and GROMACS. Removing this open issue closes #8

For our first beta release we should just be at revision 1,
then  later updates to a merged spec can bump this when we
feel is appropriate.

This patch also removes the issue about whether executable
graph update is valuable to users, as we've found evidence of the equivalent
CUDA functionality in pytorch, tensorflow, and GROMACS. Removing this
open issue closes #8
@EwanC EwanC added the Graph Specification Extension Specification related label Mar 23, 2023
@EwanC EwanC requested review from reble, Bensuo and julianmi March 23, 2023 08:25
Copy link
Collaborator

@julianmi julianmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EwanC EwanC merged commit 28acfa8 into sycl-graph-update Mar 24, 2023
@EwanC EwanC deleted the ewan/squash_revision_list branch June 28, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Specification Extension Specification related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants