create VRC with flattenMode=force #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If DRPolicy is created with flattening enabled, we create 2 VRC - 1 without flattening and 1 with flattening. VRC without flattening is marked as default VRC and VRC with flattening is given a unique label. Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
flatten-vrc
branch
from
7d51e9f to
b501cd9
Compare
|
Code looks fine to me /lgtm |
openshift-merge-bot
bot
merged commit 570778d
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DRPolicy is created with flattening enabled, we create 2 VRC - 1 without flattening and 1 with flattening. VRC without flattening is marked as default VRC and VRC with flattening is given a unique label.