remove unused configuration of MultiClusterService #211
Conversation
MirrorPeer.Spec.OverlappingCIDR was added to allow users to automatically enable StorageCluster.Spec.Netowrking.MultiClusterService when needed. But this implementation had some limitations due to which it was not generally used. This commit now drops the changes completely to avoid unwanted usage. This will be replaced by alternate solutions which are more reliable. Signed-off-by: Umanga Chapagain <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration-test |
|
@umangachapagain WIll there be any impact for people already using it ? |
There shouldn't be any impact other than the fact that it will stop working. If MultiClusterService is already enabled, it will not be disabled after this. If it is disabled, it can not be enabled with this feature and needs to be enabled using other ways. |
|
/lgtm |
openshift-merge-bot
bot
merged commit acfbd5a
into
red-hat-storage:main
|
/cherry-pick release-4.16 |
|
@umangachapagain: new pull request created: #212 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
MirrorPeer.Spec.OverlappingCIDR was added to allow users to automatically enable StorageCluster.Spec.Netowrking.MultiClusterService when needed. But this implementation had some limitations due to which it was not generally used.
This commit now drops the changes completely to avoid unwanted usage. This will be replaced by alternate solutions which are more reliable.