Add slog structured logging to main controllers #213
Merged
openshift-merge-bot[bot] merged 1 commit intored-hat-storage:mainfrom Jun 25, 2024
Merged
Add slog structured logging to main controllers #213openshift-merge-bot[bot] merged 1 commit intored-hat-storage:mainfrom
slog structured logging to main controllers #213openshift-merge-bot[bot] merged 1 commit intored-hat-storage:mainfrom
Conversation
bede768 to
33c042b
Compare
umangachapagain
suggested changes
Jun 20, 2024
umangachapagain
suggested changes
Jun 20, 2024
Contributor
umangachapagain
left a comment
There was a problem hiding this comment.
Let's enable sloglint which is available via golangci-lint: https://github.com/go-simpler/sloglint?tab=readme-ov-file#-install
Member
Author
added slog lint |
umangachapagain
suggested changes
Jun 20, 2024
d1eb224 to
15a271e
Compare
umangachapagain
suggested changes
Jun 24, 2024
d11da7b to
f81bd3f
Compare
Member
Author
|
/test integration-test |
umangachapagain
suggested changes
Jun 24, 2024
662c1bf to
556f8ff
Compare
Integrated slog logging into the MirrorPeerSecretReconciler, MirrorPeerReconciler, and DRPolicyReconciler controllers.
Improved error handling and logging for better observability and debugging.
Replaced klog with slog for consistency across the codebase.
Changes include:
Added Logger field to controller structs to pass and use slog.Logger.
Enhanced logging messages to provide more context, including function names, object names, namespaces, and error details.
Signed-off-by: vbadrina <vbadrina@redhat.com>
umangachapagain
approved these changes
Jun 25, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sloglogging into theMirrorPeerSecretReconciler,MirrorPeerReconciler, andDRPolicyReconcilercontrollers.Changes include:
Loggerfield to controller structs to pass and useslog.Logger.Example of the change -