Skip to content

[release-4.18] DFBUGS-2224: ensure OBC spec is not reset unexpectedly #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[release-4.18] DFBUGS-2224: ensure OBC spec is not reset unexpectedly #319

merged 1 commit into from
Apr 24, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #316

/assign umangachapagain

@umangachapagain
ensure OBC spec is not reset unexpectedly
7371647 
When creating or updating an OBC, we only manage certain fields.
There are other fields managed by other agents. We should not reset
those fields whhen we update the resource.

Signed-off-by: Umanga Chapagain <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 21, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-2276](https://issues.redhat.com//browse/DFBUGS-2276) has been cloned as [Jira Issue DFBUGS-2296](https://issues.redhat.com//browse/DFBUGS-2296). Will retitle bug to link to clone.
/retitle [release-4.18] DFBUGS-2296: ensure OBC spec is not reset unexpectedly

In response to this:

This is an automated cherry-pick of #316

/assign umangachapagain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] DFBUGS-2276: ensure OBC spec is not reset unexpectedly [release-4.18] DFBUGS-2296: ensure OBC spec is not reset unexpectedly Apr 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-2296](https://issues.redhat.com//browse/DFBUGS-2296), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #316

/assign umangachapagain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain umangachapagain changed the title [release-4.18] DFBUGS-2296: ensure OBC spec is not reset unexpectedly [release-4.18] DFBUGS-2224: ensure OBC spec is not reset unexpectedly Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-2224](https://issues.redhat.com//browse/DFBUGS-2224), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #316

/assign umangachapagain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@umangachapagain: This pull request references [Jira Issue DFBUGS-2224](https://issues.redhat.com//browse/DFBUGS-2224), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@umangachapagain: This pull request references Jira Issue DFBUGS-2224, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm label Apr 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7f49789 into red-hat-storage:release-4.18 Apr 24, 2025
9 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-2224](https://issues.redhat.com//browse/DFBUGS-2224): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-2224](https://issues.redhat.com//browse/DFBUGS-2224) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #316

/assign umangachapagain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

Assignees

@umangachapagain umangachapagain

Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @umangachapagain