Skip to content

DFBUGS-2308: add or remove VRC from StorageConsumer as required #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

DFBUGS-2308: add or remove VRC from StorageConsumer as required #320

merged 2 commits into from
Apr 30, 2025

Conversation

umangachapagain
Copy link
Contributor

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umangachapagain umangachapagain changed the title add or remove VRC from StorageConsumer as required DFBUGS-2308: add or remove VRC from StorageConsumer as required Apr 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2025 •
edited by openshift-ci bot
Loading

@umangachapagain: This pull request references [Jira Issue DFBUGS-2308](https://issues.redhat.com//browse/DFBUGS-2308), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain umangachapagain force-pushed the uninstall-vrc branch 2 times, most recently from aaf498e to 7fe4182 Compare April 22, 2025 10:41
@umangachapagain umangachapagain added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 23, 2025
@umangachapagain umangachapagain requested a review from vbnrh April 23, 2025 07:04
rewantsoni
rewantsoni suggested changes Apr 23, 2025
View reviewed changes
@umangachapagain
Copy link
Contributor Author

@rewantsoni I'll address the nitpicks later on since there is no functional difference.

@rewantsoni
Copy link
Member

@umangachapagain #320 (comment) is yet to be resolved

vbnrh
vbnrh suggested changes Apr 23, 2025
View reviewed changes
rewantsoni
rewantsoni reviewed Apr 29, 2025
View reviewed changes
@rewantsoni
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d8b101a into red-hat-storage:main Apr 30, 2025
9 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025 •
edited by openshift-ci bot
Loading

@umangachapagain: [Jira Issue DFBUGS-2308](https://issues.redhat.com//browse/DFBUGS-2308): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-2308](https://issues.redhat.com//browse/DFBUGS-2308) has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain umangachapagain deleted the uninstall-vrc branch April 30, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nb-ohad nb-ohad Awaiting requested review from nb-ohad

@vbnrh vbnrh Awaiting requested review from vbnrh

@rewantsoni rewantsoni Awaiting requested review from rewantsoni

Assignees

@rewantsoni rewantsoni

@vbnrh vbnrh

Labels
approved jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umangachapagain @openshift-ci-robot @rewantsoni @nb-ohad @vbnrh