Skip to content

DFBUGS-2370: [release-4.18] Fix storageid generation #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

umangachapagain
Copy link
Contributor

@umangachapagain umangachapagain commented Apr 29, 2025

There can be cases where Ceph FSID is not yet initialized or missing from the server response. In such cases, it is better to error out early than to proceed with incorrect state.

We also reconcile all blue secrets irrespective of the changes to ensure that we do not miss out on any updates. Additionally, we watch CephCluster for FSID changes.

Backport of #323

There can be cases where Ceph FSID is not yet initialized or missing
from the server response. In such cases, it is better to error out
early than to proceed with incorrect state.

We also reconcile all blue secrets irrespective of the changes to
ensure that we do not miss out on any updates. Additionally, we
watch CephCluster for FSID changes.

Signed-off-by: Umanga Chapagain <[email protected]>
@umangachapagain umangachapagain changed the title [release-4.18] Fix storageid generation DFBUGS-2370: [release-4.18] Fix storageid generation Apr 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@umangachapagain: This pull request references [Jira Issue DFBUGS-2370](https://issues.redhat.com//browse/DFBUGS-2370), which is invalid:

  • expected the bug to target the "odf-4.18.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

There can be cases where Ceph FSID is not yet initialized or missing from the server response. In such cases, it is better to error out early than to proceed with incorrect state.

We also reconcile all blue secrets irrespective of the changes to ensure that we do not miss out on any updates. Additionally, we watch CephCluster for FSID changes.

Backport of #323

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Apr 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@umangachapagain: This pull request references [Jira Issue DFBUGS-2370](https://issues.redhat.com//browse/DFBUGS-2370), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.3) matches configured target version for branch (odf-4.18.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Apr 29, 2025
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@umangachapagain: This pull request references [Jira Issue DFBUGS-2370](https://issues.redhat.com//browse/DFBUGS-2370), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.3) matches configured target version for branch (odf-4.18.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vbnrh
Copy link
Member

vbnrh commented Apr 29, 2025

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [umangachapagain,vbnrh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df33081 into red-hat-storage:release-4.18 Apr 29, 2025
9 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@umangachapagain: [Jira Issue DFBUGS-2370](https://issues.redhat.com//browse/DFBUGS-2370): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-2370](https://issues.redhat.com//browse/DFBUGS-2370) has been moved to the MODIFIED state.

In response to this:

There can be cases where Ceph FSID is not yet initialized or missing from the server response. In such cases, it is better to error out early than to proceed with incorrect state.

We also reconcile all blue secrets irrespective of the changes to ensure that we do not miss out on any updates. Additionally, we watch CephCluster for FSID changes.

Backport of #323

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umangachapagain umangachapagain deleted the fix-storageid-generation branch April 29, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants