DFBUGS-5257: [release-4.17] remove GenerationChange and LabelChange predicates for secret#372
Conversation
remove GenerationChange and LabelChange predicate for secrets, and update the existing secrets during reconcile if the data is changed due to changes in cephcluster. Signed-off-by: Nikhil-Ladha <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@Nikhil-Ladha: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Nikhil-Ladha: This pull request references [Jira Issue DFBUGS-5257](https://issues.redhat.com//browse/DFBUGS-5257), which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
remove GenerationChange and LabelChange predicate for secrets, and update the existing secrets during reconcile if the data is changed due to changes in cephcluster.
Keeping it consistent with 4.18 changes made as part of commits fec71e6 and f4ec048#diff-ef7b31ff5490bc83b4f3838ea7b2f4b2f0bdea9d28c35c4bbcbac265e8db7c5c