Skip to content

DFBUGS-5257: [release-4.17] remove GenerationChange and LabelChange predicates for secret#372

Open
Nikhil-Ladha wants to merge 1 commit intored-hat-storage:release-4.17from
Nikhil-Ladha:fix-secrets-update-4.17
Open

DFBUGS-5257: [release-4.17] remove GenerationChange and LabelChange predicates for secret#372
Nikhil-Ladha wants to merge 1 commit intored-hat-storage:release-4.17from
Nikhil-Ladha:fix-secrets-update-4.17

Conversation

@Nikhil-Ladha
Copy link
Member

remove GenerationChange and LabelChange predicate for secrets, and update the existing secrets during reconcile if the data is changed due to changes in cephcluster.
Keeping it consistent with 4.18 changes made as part of commits fec71e6 and f4ec048#diff-ef7b31ff5490bc83b4f3838ea7b2f4b2f0bdea9d28c35c4bbcbac265e8db7c5c

remove GenerationChange and LabelChange predicate for secrets,
and update the existing secrets during reconcile if the data is
changed due to changes in cephcluster.

Signed-off-by: Nikhil-Ladha <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nikhil-Ladha
Once this PR has been reviewed and has the lgtm label, please assign vbnrh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nikhil-Ladha
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@Nikhil-Ladha: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Nikhil-Ladha Nikhil-Ladha changed the title DFBUGS-5257 [release-4.17] remove GenerationChange and LabelChange predicates for secret DFBUGS-5257: [release-4.17] remove GenerationChange and LabelChange predicates for secret Jan 13, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@Nikhil-Ladha: This pull request references [Jira Issue DFBUGS-5257](https://issues.redhat.com//browse/DFBUGS-5257), which is invalid:

  • expected the bug to target the "odf-4.17.19" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

remove GenerationChange and LabelChange predicate for secrets, and update the existing secrets during reconcile if the data is changed due to changes in cephcluster.
Keeping it consistent with 4.18 changes made as part of commits fec71e6 and f4ec048#diff-ef7b31ff5490bc83b4f3838ea7b2f4b2f0bdea9d28c35c4bbcbac265e8db7c5c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants