Skip to content

(#2156780) logind-session: make stopping of idle session visible to admins#364

Merged
jamacku merged 1 commit intoredhat-plumbers:masterfrom
dtardon:bz2156780-stop-idle-log
Feb 27, 2023
Merged

(#2156780) logind-session: make stopping of idle session visible to admins#364
jamacku merged 1 commit intoredhat-plumbers:masterfrom
dtardon:bz2156780-stop-idle-log

Conversation

@dtardon
Copy link
Member

@dtardon dtardon commented Feb 22, 2023

(cherry picked from commit 6269ffe7ee8a659df7336a2582054ecd9eecf4b1)

Resolves: #2156780

(cherry picked from commit 6269ffe7ee8a659df7336a2582054ecd9eecf4b1)

Resolves: #2156780
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Feb 22, 2023
@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Feb 22, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title logind-session: make stopping of idle session visible to admins (#2156780) logind-session: make stopping of idle session visible to admins Feb 22, 2023
@systemd-rhel-bot systemd-rhel-bot added the tracker/unapproved Formerly needs-acks label Feb 22, 2023
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Feb 27, 2023
@jamacku
Copy link
Member

jamacku commented Feb 27, 2023

@mrc0mmand Is ci failure expected? It seems related. Thanks

@mrc0mmand
Copy link
Member

@mrc0mmand Is ci failure expected? It seems related. Thanks

It's not related to this PR, the test is just extremely racy (see #346 (comment)). /cc @dtardon

@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Feb 27, 2023
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Feb 27, 2023
@dtardon
Copy link
Member Author

dtardon commented Feb 27, 2023

It seems the test for #346 is not reliable enough after all. I really don't want to backport later improvements to it, as they depend on general improvements to TEST-35-LOGIN, so we probably should disable it.

@jamacku jamacku added this to the RHEL-8.8 milestone Feb 27, 2023
@dtardon
Copy link
Member Author

dtardon commented Feb 27, 2023

It seems the test for #346 is not reliable enough after all. I really don't want to backport later improvements to it, as they depend on general improvements to TEST-35-LOGIN, so we probably should disable it.

Or we could just pick up the necessary minimum that's needed to run the test from the current upstream version instead of backporting separate commits (which didn't even occur to me when I was doing the backport, because I'm too used to the latter). That shouldn't be that much work...

@jamacku jamacku merged commit b18e19f into redhat-plumbers:master Feb 27, 2023
@dtardon dtardon deleted the bz2156780-stop-idle-log branch February 27, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants