Skip to content

(#2176892) Make sure journalctl --flush does not hang#365

Merged
jamacku merged 3 commits intoredhat-plumbers:masterfrom
dtardon:bz2174645-journal-flush
Mar 13, 2023
Merged

(#2176892) Make sure journalctl --flush does not hang#365
jamacku merged 3 commits intoredhat-plumbers:masterfrom
dtardon:bz2174645-journal-flush

Conversation

@dtardon
Copy link
Member

@dtardon dtardon commented Mar 13, 2023

This is not a change I'm proud of, but it fixes the regression and it is good enough for the original use case...

Resolves: #2176892

@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Mar 13, 2023
@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Mar 13, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title Make sure journalctl --flush does not hang (#2174645) Make sure journalctl --flush does not hang Mar 13, 2023
`journalctl --flush` waits on that file, so we must create if even if
nothing has really happened.

RHEL-only

Resolves: #2176892
@systemd-rhel-bot systemd-rhel-bot added the tracker/unapproved Formerly needs-acks label Mar 13, 2023
dtardon added 2 commits March 13, 2023 15:21
No functional change, just refactoring.

RHEL-only

Related: #2176892
`journalctl --relinquish-var` waits on that file, so we must create if
even if nothing has really happened.

RHEL-only

Related: #2176892
@dtardon dtardon force-pushed the bz2174645-journal-flush branch from edf9dae to 4801e55 Compare March 13, 2023 14:21
@dtardon dtardon added this to the RHEL-8.9 milestone Mar 13, 2023
@msekletar
Copy link
Member

CI failure is the same as in #366.

Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed pr/needs-review Formerly needs-review tracker/unapproved Formerly needs-acks labels Mar 13, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Mar 13, 2023
@jamacku jamacku merged commit 05a06e3 into redhat-plumbers:master Mar 13, 2023
@dtardon dtardon deleted the bz2174645-journal-flush branch March 14, 2023 07:21
@dtardon dtardon changed the title (#2174645) Make sure journalctl --flush does not hang (#2176892) Make sure journalctl --flush does not hang Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants