Skip to content

Fix: Core Synth #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Fix: Core Synth #241

merged 2 commits into from
Aug 26, 2025

Conversation

akwasigroch
Copy link
Collaborator

This PR introduces changes from the fix/core-synth branch.

📝 Summary

📁 Files Changed ( 8 files)

sdk/src/rhesis/sdk/services/extractor.py
sdk/src/rhesis/sdk/synthesizers/__init__.py
sdk/src/rhesis/sdk/synthesizers/assets/prompt_synthesizer.md
sdk/src/rhesis/sdk/synthesizers/base.py
sdk/src/rhesis/sdk/synthesizers/paraphrasing_synthesizer.py
sdk/src/rhesis/sdk/synthesizers/prompt_synthesizer.py
sdk/src/rhesis/sdk/synthesizers/utils.py
tests/sdk/synthesizers/prompt_synthesizer/test_document_extraction.py

📋 Commit Details

35c5914 - fix: clean up __init__.py imports after PR merge (Emanuele De Rossi, 2025-08-26 10:18)
188f55a - Revert "Merge pull request #238 from rhesis-ai/revert-232-feature/core-prompt-synthesizer-implementation-208" (Arkadiusz Kwasigroch, 2025-08-26 11:25)

✅ Checklist

  • Code follows the project's style guidelines
  • Self-review of code has been performed
  • Code is commented, particularly in hard-to-understand areas
  • Corresponding changes to documentation have been made
  • Tests have been added/updated for new functionality
  • All tests pass locally

🧪 Testing

📸 Screenshots (if applicable)

🔗 Related Issues

akwasigroch and others added 2 commits August 26, 2025 11:25
@akwasigroch
Revert "Merge pull request #238 from rhesis-ai/revert-232-feature/cor…
188f55a 
…e-prompt-synthesizer-implementation-208"

This reverts commit 9aa148e, reversing
changes made to c5a2b6e.
@akwasigroch
fix: clean up __init__.py imports after PR merge
35c5914 
Remove references to deleted ContextSynthesizer and DocumentSynthesizer classes.
@akwasigroch akwasigroch self-assigned this Aug 26, 2025
@akwasigroch akwasigroch added this to the Release 4 (ETA 05.09.) milestone Aug 26, 2025
@akwasigroch akwasigroch added the Tests (& Generation) Issues to tests as a main entity and generation of test cases label Aug 26, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@EmanueleDeRossi1 EmanueleDeRossi1 mentioned this pull request Aug 26, 2025
Closed
@EmanueleDeRossi1
Copy link
Collaborator

Thank you @akwasigroch for fixing the revert and cherry-picking the fix! That was a really tricky Git situation 😬

@EmanueleDeRossi1 EmanueleDeRossi1 merged commit 9900efa into main Aug 26, 2025
8 checks passed
@EmanueleDeRossi1 EmanueleDeRossi1 deleted the fix/core-synth branch August 26, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akwasigroch akwasigroch

Labels
Tests (& Generation) Issues to tests as a main entity and generation of test cases
Projects
None yet
Milestone
Release 4 (ETA 05.09.)
Development

Successfully merging this pull request may close these issues.
2 participants
@akwasigroch @EmanueleDeRossi1