Skip to content

Conversation

jahanzaibsuleman07
Copy link
Collaborator

@jahanzaibsuleman07 jahanzaibsuleman07 commented Sep 2, 2025

This PR introduces changes from the feature/comments_for_collaboration branch.

📝 Summary

📁 Files Changed ( 15 files)

apps/frontend/package-lock.json
apps/frontend/package.json
apps/frontend/src/app/(protected)/test-runs/[identifier]/page.tsx
apps/frontend/src/app/(protected)/test-sets/[identifier]/page.tsx
apps/frontend/src/app/(protected)/tests/[identifier]/page.tsx
apps/frontend/src/components/comments/CommentItem.tsx
apps/frontend/src/components/comments/CommentsSection.tsx
apps/frontend/src/components/comments/CommentsWrapper.tsx
apps/frontend/src/components/comments/index.ts
apps/frontend/src/hooks/useComments.ts
apps/frontend/src/types/comments.ts
apps/frontend/src/utils/api-client/client-factory.ts
apps/frontend/src/utils/api-client/comments-client.ts
apps/frontend/src/utils/api-client/config.ts
apps/frontend/src/utils/mock-data/comments.ts

📋 Commit Details

b81fd24 - Comments for collaboraion tests, test sets and test runs (jahanzaibsuleman07, 2025-09-02 15:28)
f8f52a9 - fe-comments-feature (jahanzaibsuleman07, 2025-09-01 15:40)

✅ Checklist

  • Code follows the project's style guidelines
  • Self-review of code has been performed
  • Code is commented, particularly in hard-to-understand areas
  • Corresponding changes to documentation have been made
  • Tests have been added/updated for new functionality
  • All tests pass locally

🧪 Testing

📸 Screenshots (if applicable)

🔗 Related Issues

@jahanzaibsuleman07 jahanzaibsuleman07 self-assigned this Sep 2, 2025
@jahanzaibsuleman07 jahanzaibsuleman07 marked this pull request as draft September 2, 2025 13:30
@jahanzaibsuleman07 jahanzaibsuleman07 linked an issue Sep 2, 2025 that may be closed by this pull request
17 tasks
@jahanzaibsuleman07 jahanzaibsuleman07 marked this pull request as ready for review September 3, 2025 13:00
@harry-rhesis
Copy link
Contributor

Great work on this PR! 🎉

The introduction of comments across test runs, test sets, and tests is a big step forward for the platform. The implementation feels flexible and well thought out, and I appreciate the consistency with patterns we already use (like emojis) as well as the smooth alignment with our frontend conventions.

Also, it’s great to see the strong collaboration with @asadaaron and @nicolai-rhesis reflected here. 👏

One recommendation: for features of this size, it’s best to commit more frequently to make the progression clearer.
Also, when changes are requested and new commits are introduced, be sure to update the PR accordingly so reviewers can easily follow along.

Overall, this is an excellent contribution—thank you for driving this forward! 🚀

@harry-rhesis harry-rhesis merged commit 64f7911 into main Sep 3, 2025
5 checks passed
@harry-rhesis harry-rhesis deleted the feature/comments_for_collaboration branch September 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Comments feature for test, test sets and test runs
2 participants