Include nested evaluator details in judge list response

[juho-y]

Includes basic details to give more context to the model

Summary by CodeRabbit

• New Features
  • Judge information now includes detailed evaluator data, providing names, IDs, and optional intent for each evaluator.
• Tests
  • Enhanced tests to verify the presence and structure of evaluator information within judge data.

[coderabbitai]

Walkthrough

A nested evaluator model was introduced within the judge schema, and the judge listing logic was updated to parse and validate evaluator information for each judge. Tests were expanded to verify the presence and structure of evaluator data in judge entries returned by the API client.

Changes

File(s)	Change Summary
src/root_signals_mcp/schema.py	Added NestedEvaluatorInfo model inside JudgeInfo and a required evaluators field (list)
src/root_signals_mcp/root_api_client.py	Updated list_judges to parse, validate, and attach nested evaluator info to each judge
src/root_signals_mcp/test/test_client.py	Enhanced test to assert presence and structure of "evaluators" in judge data

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant RootSignalsJudgeRepository
    participant JudgeInfo
    participant NestedEvaluatorInfo

    Client->>RootSignalsJudgeRepository: list_judges()
    RootSignalsJudgeRepository->>RootSignalsJudgeRepository: Fetch raw judge data
    loop For each judge
        RootSignalsJudgeRepository->>RootSignalsJudgeRepository: Extract evaluators (list)
        loop For each evaluator
            RootSignalsJudgeRepository->>NestedEvaluatorInfo: Validate & create instance
        end
        RootSignalsJudgeRepository->>JudgeInfo: Construct with evaluators list
    end
    RootSignalsJudgeRepository->>Client: Return list of JudgeInfo (with evaluators)

Loading

Poem

In the warren of code, a new friend appears,
Evaluators nested, to silence old fears.
Judges now gather, with helpers in tow,
Validated and structured, in schema they grow.
Tests hop along, ensuring all’s right—
A carrot for teamwork, and code shining bright! 🥕

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32b7826 and e444c71.

📒 Files selected for processing (3)

• src/root_signals_mcp/root_api_client.py (1 hunks)
• src/root_signals_mcp/schema.py (1 hunks)
• src/root_signals_mcp/test/test_client.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/root_signals_mcp/root_api_client.py (1)

src/root_signals_mcp/schema.py (2)

• JudgeInfo (209-225)
• NestedEvaluatorInfo (214-219)

🔇 Additional comments (5)

src/root_signals_mcp/schema.py (2)

214-220: Well-structured nested evaluator model.

The nested Pydantic model approach is clean and appropriately captures the relevant evaluator details within the judge context.

---

224-224: Appropriate inclusion of evaluators field in JudgeInfo.

Adding the evaluators list as a required field ensures judges will always have associated evaluator information, which aligns with the PR objective to provide more context to the model.

src/root_signals_mcp/test/test_client.py (1)

127-134: Good test coverage for evaluator data structure.

These assertions properly verify that the judge response includes a non-empty list of evaluators and that each evaluator contains the required fields. The tests ensure the client correctly processes the nested evaluator data from the API response.

src/root_signals_mcp/root_api_client.py (2)

438-441: Robust parsing and validation of evaluator data.

The implementation properly handles the conversion of raw evaluator data into validated Pydantic model instances, with appropriate handling of potential missing data (defaulting to an empty list).

---

447-447: Updated JudgeInfo constructor with evaluator list.

The evaluators list is correctly passed to the JudgeInfo constructor, completing the implementation of the nested evaluator details feature.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.