Updated judge execute and listing endpoints to match the new v1 syntax#26
Updated judge execute and listing endpoints to match the new v1 syntax#26TensorTemplar merged 3 commits intomainfrom
Conversation
WalkthroughThe API endpoint paths in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/root_signals_mcp/root_api_client.py(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Integration Tests with Docker Compose
src/root_signals_mcp/root_api_client.py
[error] 406-414: Pre-commit hook 'ruff-format' failed: file was reformatted due to multi-line string concatenation changed to single line. Run 'pre-commit run --all-files' locally to reproduce and fix.
🔇 Additional comments (1)
src/root_signals_mcp/root_api_client.py (1)
484-487: Endpoint update looks correctThe execute path has been migrated to
/v1/judges/{id}/execute/.
No other changes needed; signature and payload remain intact.
Styling fix Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Ari Heljakka <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/root_signals_mcp/root_api_client.py (1)
410-411: Convert boolean parameter to lowercase for API compatibility.As previously noted,
settings.show_public_judgesis a Python boolean that will be converted to capitalized "True"/"False" in the URL string, but the API likely expects lowercase "true"/"false". Apply the fix suggested in the previous review to convert both the initial URL and url_params to use lowercase boolean strings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/root_signals_mcp/root_api_client.py(2 hunks)
🧰 Additional context used
🪛 Ruff (0.11.9)
src/root_signals_mcp/root_api_client.py
410-410: SyntaxError: Expected ')', found '='
🪛 GitHub Actions: Integration Tests with Docker Compose
src/root_signals_mcp/root_api_client.py
[error] 410-410: SyntaxError: Expected ')', found '=' at line 410. Ruff linting failed due to this syntax error.
[error] 410-410: Ruff-format failed to parse file due to syntax error: Expected ')', found '=' at line 410.
🔇 Additional comments (1)
src/root_signals_mcp/root_api_client.py (1)
484-484: LGTM: Correct v1 API endpoint migration.The endpoint path has been properly updated from
/beta/judgesto/v1/judgesfor the execute operation, which aligns with the PR objective to migrate to v1 syntax.
2 participants
Summary by CodeRabbit