Skip to content

Fix rocket db pools config #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix rocket db pools config #2926

wants to merge 2 commits into from

Conversation

dfego
Copy link
Contributor

@dfego dfego commented Mar 29, 2025

See: #2925

the10thWiz
the10thWiz approved these changes May 4, 2025
View reviewed changes
Copy link
Collaborator

@the10thWiz the10thWiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not sure why the workflows didn't trigger (I'll have to look into it), but that should be the only thing left before we can merge this.

@dfego @the10thWiz
Added test for new config values
74f884d 
- Also poke by the10thwiz to trigger CI
@the10thWiz the10thWiz force-pushed the fix-rocket-db-pools-config branch from 614def9 to 74f884d Compare May 4, 2025 07:39
@the10thWiz
Copy link
Collaborator

Merged in 207e122

@the10thWiz the10thWiz closed this May 4, 2025
@the10thWiz the10thWiz added the pr: merged This pull request was merged manually. label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the10thWiz the10thWiz the10thWiz approved these changes

Assignees
No one assigned
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfego @the10thWiz