feat: display validated-async in version list and report #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azenoni
reviewed
Jun 27, 2024
src/commands/package/version/list.ts
Outdated
| @@ -249,6 +252,14 @@ const getColumnData = ( | |||
| Branch: { header: messages.getMessage('packageBranch') }, | |||
| }; | |||
|
|
|||
| if (Number(connection.version) > 60) { | |||
There was a problem hiding this comment.
Do we need to check against api version here? I don't see if for other fields we added in the past (language). It might be needed I'm just not familiar with this code path
There was a problem hiding this comment.
I believe so, we don't want the column header being populated and with empty data. This check is just for the header.
shetzel
reviewed
Jun 28, 2024
shetzel
approved these changes
Jun 28, 2024
shetzel
deleted the
mradul/managed-packaging/W-15103954/async-validation-followup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
followup from - #687
What issues does this PR fix or reference?