Skip to content

@W-16217108@ Update package_version_create.md #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

penelopy
Copy link
Collaborator

@penelopy penelopy commented Jul 11, 2024

Edited the Help text that displays with packageVersionCreatePerformingValidations and edited the definition-file flag

Edited the Help text that displays with packageVersionCreatePerformingValidations and edited the definition-file flag
@penelopy penelopy requested a review from a team as a code owner July 11, 2024 19:01
@penelopy
Copy link
Collaborator Author

@mradulsf Here is the PR with the Help text changes. Here is the WI I created. I'll ping Rob re this WI https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001wQOe3YAG/view

@mradulsf mradulsf changed the title Update package_version_create.md @W-16217108@ Update package_version_create.md Jul 11, 2024
@@ -47,7 +47,7 @@ Path to the directory that contains the contents of the package.

# flags.definition-file.summary

Path to a definition file similar to scratch org definition file that contains the list of features and org preferences that the metadata of the package version depends on.
Path to a definition file similar to scratch org definition file that contains the list of features and org preferences that the metadata of the package version depends on. For a patch version, the features specified in this file are ignored, and instead the features specified for the ancestor version are used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI that the summary is pretty long now and goes into two lines in the --help:

image

That's fine, if you're okay with it! Just wanted to point it out.

If you want to keep the summary short, you can always put this new text in a flags.definition-file.description.

Removed the addition to definition file. Will make this change in a separate PR.
@penelopy penelopy closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants