implement magic rescaling of thresholds for large filesystems#14
implement magic rescaling of thresholds for large filesystems#14
Conversation
|
will this be merged? |
Let me clean this up and line up specific reviewers. Hopefully next week. I generally don't want to Yolo merge my own PRs unless its a critical bug fix. |
|
I already know I need to do a little more work on this before its gonna pass review. I need to add some test coverage. We'll get in probably late next week. |
|
other higher priority items came up. I'm at monitorama next week but I'll try to make sure if I have time while there to do any technical work I'll on getting this brushed up. Here's my plan when i get the round toits to work on this. |
|
@jspaleta sounds good, but please clean up the merge artifacts in CHANGELOG.md |
|
haha... no i totally missed this is MY pr branch... no need for a new PR.. im gonna work in this one. I though this was a PR from a repo fork. |
|
@echlebek In particular I've added test cases for the adjPercent function to make sure its doing the sane expected behavior pushing the percentage threshold limits up/down according to whether the file system is smaller/larger than the "normal" filesystem size. |
Closes #1