Make error codes match Open Subsonic spec#671
Merged
sentriz merged 1 commit intosentriz:masterfrom Mar 10, 2026
Merged
Conversation
There were a number of error codes being returned that did not match the the code given by the spec. Primarily this was the use of error code 10 (missing input parameter) when 70 (data not found) was the more appropriate return. Though several uses of 10 are actually 0 (internal server or unspecified error). Signed-off-by: Eric B Munson <[email protected]>
Owner
|
thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a number of error codes being returned that did not match the the code given by the spec. Primarily this was the use of error code 10 (missing input parameter) when 70 (data not found) was the more appropriate return. Though several uses of 10 are actually 0 (internal server or unspecified error).