fix(core/input)- Added fix for the edge browser icon duplication issue#2391
fix(core/input)- Added fix for the edge browser icon duplication issue#23911307-Dev wants to merge 7 commits intosiemens:mainfrom
Conversation
🦋 Changeset detectedLatest commit: afb5ac0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @1307-Dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific UI anomaly in Microsoft Edge, preventing an unintended duplicate password reveal icon from appearing in Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where a duplicate password reveal icon appears in the Edge browser. The fix involves adding a CSS rule to hide the browser's native ::-ms-reveal pseudo-element, which is correct and effective. I've added one suggestion to improve code maintainability by adding a comment explaining the purpose of this browser-specific rule.
Added comment to explain css change Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1307-Dev
changed the title
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
I still see the extra icon in Edge for Mac 🤔
|
2 participants
💡 What is the current behavior?
Currently when the ix-input type password field is empty and any characters are entered into it while on revealed state, an extra icon pops up only in the edge browser to reveal the entered password.
GitHub Issue Number: #2367
JIRA Ticket: IX-3901
🆕 What is the new behavior?
The extra icon does not appear anymore.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)