Skip to content

feat(chip): improve accessibility #IX-3654 #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexkaduk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(chip): improve accessibility #IX-3654 #2420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chip-a11y-improvements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': patch
---

Improve button accessibility, integrate axe-core accessibility smoke tests for automated a11y checks
16 changes: 8 additions & 8 deletions packages/angular-standalone-test-app/src/preview-examples/chip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,35 @@ import { IxChip } from '@siemens/ix-angular/standalone';
template: `
<div class="chip">
<div class="chip-column">
<ix-chip icon="print" variant="subtle-primary" closable>Primary</ix-chip
<ix-chip icon="print" variant="primary" closable aria-label="Primary category" aria-label-close-button="Remove primary category">Primary</ix-chip
>
<ix-chip icon="print" variant="alarm" closable>Alarm</ix-chip>
<ix-chip icon="print" variant="critical">Critical</ix-chip>
<ix-chip icon="print" variant="warning">Warning</ix-chip>
<ix-chip icon="print" variant="info">Info</ix-chip>
<ix-chip icon="print" variant="success">Success</ix-chip>
<ix-chip icon="print" variant="neutral">Neutral</ix-chip>
<ix-chip icon="print" variant="custom" background="#FF00FF" closable>Custom</ix-chip
<ix-chip icon="print" variant="custom" background="#5C3FD6" chip-color="#FFFFFF" closable aria-label="Custom chip" aria-label-close-button="Remove custom chip">Custom</ix-chip
>
<ix-chip icon="print" variant="subtle-primary" closable>Chip with icon
<ix-chip icon="print" variant="primary" closable>Chip with icon
</ix-chip>
</div>
<div class="chip-column">
<ix-chip icon="print" variant="primary" closable>Primary</ix-chip>
<ix-chip icon="print" variant="alarm" closable>Alarm</ix-chip>
<ix-chip icon="print" variant="alarm" closable aria-label-close-button="Remove alarm">Alarm</ix-chip>
<ix-chip icon="print" variant="critical">Critical</ix-chip>
<ix-chip icon="print" variant="warning">Warning</ix-chip>
<ix-chip icon="print" variant="info">Info</ix-chip>
<ix-chip icon="print" variant="info" aria-label="Information tag">Info</ix-chip>
<ix-chip icon="print" variant="success">Success</ix-chip>
<ix-chip icon="print" variant="neutral">Neutral</ix-chip>
<ix-chip
variant="custom"
background="#FF00FF"
Chip-color="black"
background="#5C3FD6"
chip-color="#FFFFFF"
closable
>Custom</ix-chip
>
<ix-chip variant="subtle-primary" closable>Chip without icon </ix-chip>
<ix-chip variant="primary" closable>Chip without icon </ix-chip>
</div>
</div>
`,
Expand Down
39 changes: 31 additions & 8 deletions packages/angular-test-app/src/preview-examples/chip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,35 +15,58 @@ import { Component } from '@angular/core';
template: `
<div class="chip">
<div class="chip-column">
<ix-chip icon="print" variant="subtle-primary" closable>Primary</ix-chip
<ix-chip
icon="print"
variant="primary"
closable
aria-label="Primary category"
aria-label-close-button="Remove primary category"
>Primary</ix-chip
>
<ix-chip icon="print" variant="alarm" closable>Alarm</ix-chip>
<ix-chip icon="print" variant="critical">Critical</ix-chip>
<ix-chip icon="print" variant="warning">Warning</ix-chip>
<ix-chip icon="print" variant="info">Info</ix-chip>
<ix-chip icon="print" variant="success">Success</ix-chip>
<ix-chip icon="print" variant="neutral">Neutral</ix-chip>
<ix-chip icon="print" variant="custom" background="#FF00FF" closable>Custom</ix-chip
<ix-chip
icon="print"
variant="custom"
background="#5C3FD6"
chip-color="#FFFFFF"
closable
aria-label="Custom chip"
aria-label-close-button="Remove custom chip"
>Custom</ix-chip
>
<ix-chip icon="print" variant="subtle-primary" closable>Chip with icon
<ix-chip icon="print" variant="primary" closable
>Chip with icon
</ix-chip>
</div>
<div class="chip-column">
<ix-chip icon="print" variant="primary" closable>Primary</ix-chip>
<ix-chip icon="print" variant="alarm" closable>Alarm</ix-chip>
<ix-chip
icon="print"
variant="alarm"
closable
aria-label-close-button="Remove alarm"
>Alarm</ix-chip
>
<ix-chip icon="print" variant="critical">Critical</ix-chip>
<ix-chip icon="print" variant="warning">Warning</ix-chip>
<ix-chip icon="print" variant="info">Info</ix-chip>
<ix-chip icon="print" variant="info" aria-label="Information tag"
>Info</ix-chip
>
<ix-chip icon="print" variant="success">Success</ix-chip>
<ix-chip icon="print" variant="neutral">Neutral</ix-chip>
<ix-chip
variant="custom"
background="#FF00FF"
Chip-color="black"
background="#5C3FD6"
chip-color="#FFFFFF"
closable
>Custom</ix-chip
>
<ix-chip variant="subtle-primary" closable>Chip without icon </ix-chip>
<ix-chip variant="primary" closable>Chip without icon </ix-chip>
</div>
</div>
`,
Expand Down
107 changes: 72 additions & 35 deletions packages/core/src/components/chip/chip-mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@
$predefined-chips: alarm, critical, warning, info, neutral, success;
$border-radius: 100px;

// Placeholder for common ::after overlay styles
%after-overlay {
content: '';
display: block;
position: absolute;
width: 100%;
height: 100%;
left: 0;
border-radius: $border-radius;
pointer-events: none;
}

@mixin chip-container($interaction: true) {
.container {
display: inline-flex;
Expand All @@ -28,9 +40,11 @@ $border-radius: 100px;
height: vars.$default-control-height;
max-height: vars.$default-control-height;

@if $interaction {
&:not(.closable) {
cursor: pointer;
} @else {
}

&.closable {
cursor: default;
}

Expand Down Expand Up @@ -130,11 +144,19 @@ $border-radius: 100px;
}

@if $interaction {
&:hover {
&.closable:has(.close-button:hover) {
background-color: var(--theme-chip-primary--background--hover);
}

&:active {
&.closable:has(.close-button:active) {
background-color: var(--theme-chip-primary--background--active);
}

&:not(.closable):hover:not(:focus-visible) {
background-color: var(--theme-chip-primary--background--hover);
}

&:not(.closable):active {
background-color: var(--theme-chip-primary--background--active);
}

Expand All @@ -160,11 +182,19 @@ $border-radius: 100px;
}

@if $interaction {
&:hover {
&.closable:has(.close-button:hover) {
background-color: var(--theme-chip-primary-outline--background--hover);
}

&:active {
&.closable:has(.close-button:active) {
background-color: var(--theme-chip-primary-outline--background--active);
}

&:not(.closable):hover:not(:focus-visible) {
background-color: var(--theme-chip-primary-outline--background--hover);
}

&:not(.closable):active {
background-color: var(--theme-chip-primary-outline--background--active);
}
}
Expand All @@ -180,29 +210,17 @@ $border-radius: 100px;
color: var(--theme-color-#{$color}--contrast);

@if $interaction {
&:hover::after {
content: '';
display: block;
position: absolute;
width: 100%;
height: 100%;
&.closable:has(.close-button:hover)::after,
&:not(.closable):hover:not(:focus-visible)::after {
@extend %after-overlay;
background-color: rgba(0, 0, 0, 0.05);
left: 0;
border-radius: $border-radius;
pointer-events: none;
}

&.active::after,
&:active::after {
content: '';
display: block;
position: absolute;
width: 100%;
height: 100%;
&.closable.active::after,
&.closable:has(.close-button:active)::after,
&:not(.closable):active::after {
@extend %after-overlay;
background-color: rgba(0, 0, 0, 0.1);
left: 0;
border-radius: $border-radius;
pointer-events: none;
}
}

Expand All @@ -215,13 +233,16 @@ $border-radius: 100px;
}

@if $interaction {
&:hover::after {
content: '';
&.closable:has(.close-button:hover)::after,
&:not(.closable):hover:not(:focus-visible)::after {
@extend %after-overlay;
background-color: rgba(0, 0, 0, 0.05);
}

&.active::after,
&:active::after {
&.closable.active::after,
&.closable:has(.close-button:active)::after,
&:not(.closable):active::after {
@extend %after-overlay;
background-color: rgba(0, 0, 0, 0.1);
}
}
Expand All @@ -233,21 +254,37 @@ $border-radius: 100px;
border-color: var(--theme-color-#{$color});

@if $interaction {
&:hover::after {
&.closable:has(.close-button:hover)::after {
display: none;
}

&.closable:has(.close-button:hover) {
background-color: var(--theme-chip-outline--background--hover);
}

&.closable.active::after,
&.closable:has(.close-button:active)::after {
display: none;
}

&.closable.active,
&.closable:has(.close-button:active) {
background-color: var(--theme-chip-outline--background--active);
}

&:not(.closable):hover:not(:focus-visible)::after {
display: none;
}

&:hover {
&:not(.closable):hover:not(:focus-visible) {
background-color: var(--theme-chip-outline--background--hover);
}

&.active::after,
&:active::after {
&:not(.closable):active::after {
display: none;
}

&.active,
&:active {
&:not(.closable):active {
background-color: var(--theme-chip-outline--background--active);
}
}
Expand Down
Loading
Loading