NO-SNOW: Revocation Validation new link#1740
Open
sfc-gh-pcyrek wants to merge 8 commits intomasterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
- Coverage 72.48% 72.47% -0.02%
==========================================
Files 124 124
Lines 19781 19781
==========================================
- Hits 14339 14336 -3
- Misses 5442 5445 +3 ☔ View full report in Codecov by Sentry. |
sfc-gh-boler
approved these changes
Mar 12, 2026
sfc-gh-boler
force-pushed
the
NO-SNOW-Revocation-validator-new-link
branch
from
c5b2fde to
ce3a81f
Compare
sfc-gh-pfus
reviewed
Mar 13, 2026
| # Point the framework at the local Go driver checkout | ||
| go mod edit -replace "github.com/snowflakedb/gosnowflake=${DRIVER_DIR}" | ||
| # Update the framework to import gosnowflake v2 directly | ||
| find . -name '*.go' -exec sed -i 's|"github.com/snowflakedb/gosnowflake"|"github.com/snowflakedb/gosnowflake/v2"|g' {} + |
Collaborator
There was a problem hiding this comment.
I don't think this is a good idea. It's fragile. We should fix it in the revocation validation repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NO-SNOW: Revocation Validation new link
Checklist