Using the default priority queue rather than creating an invalid one#7
Open
djalkalai wants to merge 3 commits intosocialpandas:masterfrom
Open
Using the default priority queue rather than creating an invalid one#7djalkalai wants to merge 3 commits intosocialpandas:masterfrom
djalkalai wants to merge 3 commits intosocialpandas:masterfrom
Conversation
… is not found in Sidekiq::Priority.priorities in the default queue, rather than creating a new one.
…y that is not in Sidekiq::Priority.priorities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying priority queue creation to place a job with a priority that is not found in Sidekiq::Priority.priorities in the default queue, rather than creating a new invalid one. This prevents a possible user error from placing jobs into a queue that is not being processed, placing them instead into the default queue.