[WIP] Factor out fakedls.DlsNode#101
Open
gavin-norman-sociomantic wants to merge 2 commits intosociomantic-tsunami:v15.x.xfrom
Open
[WIP] Factor out fakedls.DlsNode#101gavin-norman-sociomantic wants to merge 2 commits intosociomantic-tsunami:v15.x.xfrom
gavin-norman-sociomantic wants to merge 2 commits intosociomantic-tsunami:v15.x.xfrom
Conversation
gavin-norman-sociomantic
requested review from
mihails-strasuns-sociomantic and
nemanja-boric-sociomantic
Author
|
I believe the separation of turtle node from the actual node implementation is a historical artefact from the days when the fake nodes lived partially in turtle. It seems to be unnecessary now. |
Author
|
Requires sociomantic-tsunami/swarm#353. |
added 2 commits
August 8, 2018 12:11
gavin-norman-sociomantic
force-pushed
the
nodeenv
branch
from
82b5643 to
be09150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code structure was:
DlsNode : swarm.node.model.NeoNode.NodeBase!(DlsConnectionHandler)Dls!(DlsNode) : turtle.env.model.Node.Node(the latter in swarm)So the aspects of the node that integrate with turtle were separated from the actual node implementation.
The new structure is:
turtle.env.Dls.Dls : TestNode!(DlsConnectionHandler)(the former in dlsproto)