Add new connection error notifier and error field to union#392
Add new connection error notifier and error field to union#392matthias-wende-sociomantic wants to merge 1 commit intosociomantic-tsunami:v6.x.xfrom
Conversation
|
Blocked on testing to confirm that the theory works in practice. |
3347342 to
7e4d63d
Compare
The user provided connection notifier was called on startup only in case of an successfully established connection or if an error happened while connecting. This patch adds a new (internal) client connection error notifier that is called from the ISelectClient `error` method, in that case the client Connection class. That happens when the ISelectClient is unregistered from epoll due to a exception thrown in the RequestOnConn fiber. The exception is passed to the user by utilizing a new error field in the ConnNotificationUnion (defined in the ConnectionSet).
7e4d63d to
fdecb3a
Compare
|
Changed base branch for testing. The actual patch should be merged into v6.x.x (i.e. the next major) though. |
|
Tested with my POC Could it be that its because this is not an exception, but an error, and is not caught by the base code? Just speculating here... |
The user provided connection notifier was called on startup only in case
of an successfully established connection or if an error happened while
connecting. This patch adds a new (internal) client connection error
notifier that is called from the ISelectClient
errormethod, in thatcase the client Connection class. That happens when the ISelectClient is
unregistered from epoll due to a exception thrown in the RequestOnConn
fiber.
The exception is passed to the user by utilizing a new error field in
the ConnNotificationUnion (defined in the ConnectionSet).