fix: skill install 500 error and chart dimension warnings#447
Conversation
- Fix skill install API returning 500 for single-skill repos by always using 3-part spec format (owner/repo/skill-name) instead of bare owner/repo format that the backend rejects - Fix recharts "width/height should be greater than 0" warnings by adding min-width/min-height constraints to ResponsiveContainer components and their parent divs Fixes browser console errors: - /api/agents/skills/install 500 errors when installing single-skill repos - Chart dimension warnings on AgentDetail page
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo files updated: AgentDetail.tsx with layout constraint adjustments to chart wrapper containers and ResponsiveContainer components for rendering stability, and AgentSkills.tsx with a logic change to enforce a consistent three-part installation specification format (owner/repo/skill-name). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
Summary
Fixes two issues causing browser console errors:
1. Skill Install 500 Error
The frontend sent bare
owner/repoformat for single-skill repos (where repo name equals skill ID), but the backend explicitly rejects 2-part specs with:Fix: Always use 3-part spec format
owner/repo/skill-nameregardless of repo structure.2. Chart Dimension Warnings
Recharts was logging warnings about negative dimensions:
Fix: Added
minWidth={100} minHeight={100}to allResponsiveContainercomponents andmin-h-[192px]/min-h-[160px]to parent containers.Test Plan
vercel-labs/agent-browser) - should succeed with 200anthropics/skills/pdf) - should continue to work🤖 Generated with Claude Code