Skip to content

fix: skill install 500 error and chart dimension warnings#447

Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom
vsumner:fix/skill-install-and-chart-warnings
Mar 20, 2026
Merged

fix: skill install 500 error and chart dimension warnings#447
jamiepine merged 1 commit intospacedriveapp:mainfrom
vsumner:fix/skill-install-and-chart-warnings

Conversation

@vsumner
Copy link
Collaborator

@vsumner vsumner commented Mar 16, 2026

Summary

Fixes two issues causing browser console errors:

1. Skill Install 500 Error

The frontend sent bare owner/repo format for single-skill repos (where repo name equals skill ID), but the backend explicitly rejects 2-part specs with:

bare owner/repo format is not supported — specify the skill name: owner/repo/SKILL_NAME

Fix: Always use 3-part spec format owner/repo/skill-name regardless of repo structure.

2. Chart Dimension Warnings

Recharts was logging warnings about negative dimensions:

The width(-1) and height(-1) of chart should be greater than 0

Fix: Added minWidth={100} minHeight={100} to all ResponsiveContainer components and min-h-[192px] / min-h-[160px] to parent containers.

Test Plan

  • Install a single-skill repo (e.g., vercel-labs/agent-browser) - should succeed with 200
  • Install a multi-skill repo (e.g., anthropics/skills/pdf) - should continue to work
  • Navigate to Agent Detail page - chart warnings should not appear in console

🤖 Generated with Claude Code

- Fix skill install API returning 500 for single-skill repos by always
  using 3-part spec format (owner/repo/skill-name) instead of bare
  owner/repo format that the backend rejects

- Fix recharts "width/height should be greater than 0" warnings by
  adding min-width/min-height constraints to ResponsiveContainer
  components and their parent divs

Fixes browser console errors:
- /api/agents/skills/install 500 errors when installing single-skill repos
- Chart dimension warnings on AgentDetail page
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9e1e59ff-1a86-48de-966e-4bd5978280c3

📥 Commits

Reviewing files that changed from the base of the PR and between ed3aebe and f6feb22.

📒 Files selected for processing (2)
  • interface/src/routes/AgentDetail.tsx
  • interface/src/routes/AgentSkills.tsx

Walkthrough

Two files updated: AgentDetail.tsx with layout constraint adjustments to chart wrapper containers and ResponsiveContainer components for rendering stability, and AgentSkills.tsx with a logic change to enforce a consistent three-part installation specification format (owner/repo/skill-name).

Changes

Cohort / File(s) Summary
Chart Layout Constraints
interface/src/routes/AgentDetail.tsx
Modified MemoryGrowthChart, ProcessActivityChart, and MemoryDonut to replace fixed heights with minimum heights; added explicit minWidth and minHeight properties (100px) to ResponsiveContainer instances.
Skill Installation Specification
interface/src/routes/AgentSkills.tsx
Simplified installSpec logic to unconditionally return three-part format (owner/repo/skill-name) by using ${skill.source}/${skill.skillId}; removed conditional branch for single-skill repository handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • jamiepine
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main changes: fixing a skill install 500 error and addressing chart dimension warnings that are both mentioned in the PR objectives.
Description check ✅ Passed The description is directly related to the changeset, providing detailed context about both issues being fixed, the specific backend error behavior, and a concrete test plan for verification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@jamiepine jamiepine merged commit 7c7077e into spacedriveapp:main Mar 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants