fix: close admin client after describing broker config#93
Merged
Conversation
The describeConfigStr and describeConfigStrWithConfig functions created Kafka admin clients without closing them, leaking connections. Under constrained CI environments this caused connection refused errors during the prepare phase of alter actions.
joshiste
force-pushed
the
fix/admin-client-connection-leak
branch
from
6ae68a1 to
3af6270
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describeConfigStranddescribeConfigStrWithConfig— admin clients were created but never closedconnection refusederrors in CI during the prepare phase of alter actions (limit connection creation rate, reduce max message bytes)Test plan