tests: Make sure iscsi-init.service is started for iSCSI tests #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR enhances the iSCSI test setup by adding a Jenkins mode flag, ensuring the iscsi-init service is started in tests, and including the udisks2-iscsi package as a test dependency in Ansible playbooks. Sequence diagram for starting iscsi-init.service in iSCSI test setupsequenceDiagram
participant TestRunner
participant Systemd
participant iSCSIService as iscsi-init.service
TestRunner->>Systemd: Start iscsi-init.service (in setUp)
Systemd->>iSCSIService: Activate service
iSCSIService-->>Systemd: Service started
Systemd-->>TestRunner: Confirmation of service start
TestRunner->>TestRunner: Proceed with iSCSI tests
Class diagram for updated iSCSI test setupclassDiagram
class ISCSITest {
+setUp()
+test_iscsi_functionality()
}
ISCSITest : +setUp() now starts iscsi-init.service
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @vojtechtrefny - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This includes tests that are skipped when running in non-CI environment.
vojtechtrefny
force-pushed
the
main_isicsi-startup
branch
from
dffccbd to
a52d4ee
Compare
vojtechtrefny
force-pushed
the
main_isicsi-startup
branch
from
11aedca to
a52d4ee
Compare
There was a problem hiding this comment.
Hey @vojtechtrefny - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tests/storage_tests/iscsi_test.py:115` </location>
<code_context>
except RuntimeError as e:
raise RuntimeError("Failed to setup targetcli device for testing: %s" % e)
+ subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL)
+
def _force_logout(self):
</code_context>
<issue_to_address>
Consider asserting that iscsi-init.service started successfully.
The test setup does not verify if 'iscsi-init.service' starts successfully, which could cause tests to run in an invalid state. Please check the return code and fail early if the service fails to start.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL)
=======
ret = subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL)
if ret != 0:
raise RuntimeError("Failed to start iscsi-init.service (systemctl exit code: %d)" % ret)
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -112,6 +112,8 @@ def setUp(self): | |||
| except RuntimeError as e: | |||
| raise RuntimeError("Failed to setup targetcli device for testing: %s" % e) | |||
|
|
|||
| subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL) | |||
There was a problem hiding this comment.
suggestion (testing): Consider asserting that iscsi-init.service started successfully.
The test setup does not verify if 'iscsi-init.service' starts successfully, which could cause tests to run in an invalid state. Please check the return code and fail early if the service fails to start.
Suggested change
| subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL) | |
| ret = subprocess.call(["systemctl", "start", "iscsi-init.service"], stdout=subprocess.DEVNULL) | |
| if ret != 0: | |
| raise RuntimeError("Failed to start iscsi-init.service (systemctl exit code: %d)" % ret) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for CI-specific tests and improve iSCSI test setup
New Features:
Enhancements: