tests: Do not patch builtins.open directly

[vojtechtrefny]

This causes coverity to fail, because it internally uses open() which we just mocked.

Summary by Sourcery

Update LVM unit tests to patch the open function in the module under test instead of mocking builtins.open to avoid interfering with external tools like Coverity

Bug Fixes:

• Prevent Coverity analysis failures by limiting open() mocking to the target module namespace

Tests:

• Patch open in blivet.devicelibs.lvm rather than builtins.open across LVM tests

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Tests updated to mock the module-level open in blivet.devicelibs.lvm instead of patching builtins.open, isolating file operations within the lvm code and avoiding interference with Coverity’s own file usage.

File-Level Changes

Change	Details	Files
Updated mock target for open from builtins.open to blivet.devicelibs.lvm.open	test_lvm_autoactivation initial disable-error scenario test_lvm_autoactivation write-and-verify scenario test_reenable_lvm_autoactivation error scenarios test_reenable_lvm_autoactivation write-and-verify scenario	tests/unit_tests/devicelibs_test/lvm_test.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `tests/unit_tests/devicelibs_test/lvm_test.py:20` </location>
<code_context>
    def test_lvm_autoactivation(self):
        localconf = "global { event_activation = 0 }"

        with patch("blivet.devicelibs.lvm.open", mock_open(read_data=localconf)):
            # already disabled
            with self.assertRaises(RuntimeError):
                lvm.disable_lvm_autoactivation()

        localconf = ""
        with patch("blivet.devicelibs.lvm.open", mock_open(read_data=localconf)) as m:
            lvm.disable_lvm_autoactivation()
            m.assert_called_with("/etc/lvm/lvmlocal.conf", "a")
            handle = m()
            handle.write.assert_called_once_with("global { event_activation = 0 }")

        localconf = "test\ntest"
        with patch("blivet.devicelibs.lvm.open", mock_open(read_data=localconf)) as m:
            # not disabled
            with self.assertRaises(RuntimeError):
                lvm.reenable_lvm_autoactivation()

        localconf = "# global { event_activation = 0 }"
        with patch("blivet.devicelibs.lvm.open", mock_open(read_data=localconf)) as m:
            # not disabled
            with self.assertRaises(RuntimeError):
                lvm.reenable_lvm_autoactivation()

        localconf = "test\nglobal { event_activation = 0 }"
        with patch("blivet.devicelibs.lvm.open", mock_open(read_data=localconf)) as m:
            lvm.reenable_lvm_autoactivation()
            m.assert_called_with("/etc/lvm/lvmlocal.conf", "w+")
            handle = m()
            handle.write.assert_called_once_with("test\n")

</code_context>

<issue_to_address>
**issue (code-quality):** Extract duplicate code into method ([`extract-duplicate-method`](https://docs.sourcery.ai/Reference/Default-Rules/refactorings/extract-duplicate-method/))
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}