[Lang] More evaluative build_for #8658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/rebase |
for more information, see https://pre-commit.ci
taichi-gardener
force-pushed
the
more_evaluative_build_for
branch
from
308ddf8 to
351c23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build ast for "for loop", decorators like "static", "grouped", exprs like "ndrange" are detected directly from ast. However, "mesh-for" is detected via evaluating the iterable statement's value.
I made some change that using similar evaluation to detect "grouped" and "ndrange" so that end user can wrap these method into there own iterable.
I'm motivated when developing a type hint rich wrapper for taichi, during which I found no way to wrap "grouped" nor "ndrange" into typed one.