-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[lang] Update minimum requirement for CMAKE #8703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Note: @linull24
|
I've seen #8697.After four dummy commits , and it finally worked.🤣🤣🤣. |
@linull24 Looks like an temporary infa issue: Probably good to retry another dummy commit. |
@hughperkins please review |
Hi @linull24 I'm just a bystander, and have no access to merge, but the changes look great to me. You're just going to have to keep pushing dummy commits until the tests pass I feel :). It might take a few days. I think the PR is very useful, to avoid error messages about cmake version :) |
Issue: #8673
Brief Summary
copilot:summary
This PR resolves CMake 4.0 compilation failures by standardizing the minimum required version to 3.17 across all submodules (TaichiExamples/TaichiCAPITests/TaichiCAPI/TaichiTests), ensuring compatibility with modern Linux distributions.
Walkthrough
copilot:walkthrough
Context
Changes Made
TaichiExamples.cmake
TaichiCAPITests.cmake
TaichiCAPI.cmake
TaichiTests.cmake
Impact Analysis
Verification
Additional Notes
I sincerely apologize for the additional PR noise (#8701, #8678). Due to my initial lack of Git proficiency, I inadvertently created redundant PRs while attempting to sync with upstream. This new PR (#8703) consolidates all changes with proper rebasing.
Thank you for your patience, and I appreciate your guidance throughout this process.