Skip to content

fix: Remove erroneous pod_properties scoping from job definition variable attribute structure #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryantbiggs merged 1 commit into from
Jul 1, 2025
Merged

fix: Remove erroneous pod_properties scoping from job definition variable attribute structure #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,19 +452,19 @@ resource "aws_batch_job_definition" "this" {
}
}

dns_policy = eks_properties.value.pod_properties.dns_policy
host_network = eks_properties.value.pod_properties.host_network
dns_policy = eks_properties.value.dns_policy
host_network = eks_properties.value.host_network

dynamic "image_pull_secret" {
for_each = eks_properties.value.pod_properties.image_pull_secrets != null ? eks_properties.value.pod_properties.image_pull_secrets : []
for_each = eks_properties.value.image_pull_secrets != null ? eks_properties.value.image_pull_secrets : []

content {
name = image_pull_secret.value.name
}
}

dynamic "init_containers" {
for_each = eks_properties.value.pod_properties.init_containers != null ? eks_properties.value.pod_properties.init_containers : {}
for_each = eks_properties.value.init_containers != null ? eks_properties.value.init_containers : {}

content {
args = init_containers.value.args
Expand Down Expand Up @@ -517,18 +517,18 @@ resource "aws_batch_job_definition" "this" {
}

dynamic "metadata" {
for_each = eks_properties.value.pod_properties.metadata != null ? [eks_properties.value.pod_properties.metadata] : []
for_each = eks_properties.value.metadata != null ? [eks_properties.value.metadata] : []

content {
labels = metadata.value.labels
}
}

service_account_name = eks_properties.value.pod_properties.service_account_name
share_process_namespace = eks_properties.value.pod_properties.share_process_namespace
service_account_name = eks_properties.value.service_account_name
share_process_namespace = eks_properties.value.share_process_namespace

dynamic "volumes" {
for_each = eks_properties.value.pod_properties.volumes != null ? eks_properties.value.pod_properties.volumes : {}
for_each = eks_properties.value.volumes != null ? eks_properties.value.volumes : {}

content {
dynamic "empty_dir" {
Expand Down
Loading