Skip to content

fix: Fix example of alarm with anomaly detection #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

mcantinqc
Copy link
Contributor

@mcantinqc mcantinqc commented Mar 11, 2025

Description

The example is invalid, from the documentation return_data must be use only once by alarm.

Note, the official documentation also have the same error in the example: hashicorp/terraform-provider-aws#41780.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title docs: Fix alarm with anomaly detection fix: Fix alarm with anomaly detection Mar 11, 2025
@antonbabenko antonbabenko changed the title fix: Fix alarm with anomaly detection fix: Fix example of alarm with anomaly detection Mar 11, 2025
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if you say so :)

@antonbabenko antonbabenko merged commit 698cd72 into terraform-aws-modules:master Mar 11, 2025
5 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 11, 2025
## [5.7.1](v5.7.0...v5.7.1) (2025-03-11)

### Bug Fixes

* Fix example of alarm with anomaly detection ([#77](#77)) ([698cd72](698cd72))
@antonbabenko
Copy link
Member

This PR is included in version 5.7.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants