feat: Add option to ignore container_definitions changes to ECS task definition#398
Open
dhoppe wants to merge 3 commits intoterraform-aws-modules:masterfrom
Open
feat: Add option to ignore container_definitions changes to ECS task definition#398dhoppe wants to merge 3 commits intoterraform-aws-modules:masterfrom
container_definitions changes to ECS task definition#398dhoppe wants to merge 3 commits intoterraform-aws-modules:masterfrom
Conversation
dhoppe
force-pushed
the
ignore_container_definition_changes
branch
from
97cf8ab to
8541ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the meta-argument
lifecycleto ignore changes related tocontainer_definitions.Motivation and Context
In some situations where Team A manages the AWS infrastructure and Team B manages the deployments of AWS ECS services, we might end up in situations where the tag of a Docker image is not up to date and Terraform should not do a rollback.
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestFor some reason the pre-commit hook
terraform_docsfailed withexit code: 1.Edit: I was able to solve the pre-commit issue. @antonbabenko, @bryantbiggs It would be great to get this merged.