-
Notifications
You must be signed in to change notification settings - Fork 48
Use Python 3.13 as newest Python version for pytest workflow #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR extends CI testing and project metadata to formally support Python 3.13 by updating the GitHub Actions workflow matrix and adding the new classifier. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great to me. One minor point: do we want to test against all Python versions for Python >= 3.9 instead of ['3.9', '3.13']
? This might lead to longer test durations, but more structured testing guarantees our package functions effectively across all versions.
I think it makes sense to test on more Python version, but does indeed become slower. We might also consider testing on all Python version on Linux only. Similarly, we can test on all OSes with just one Python version? (Testing is notably slower on macOS virtual machines.) |
This proposal looks great. How about this? We only test Python 3.13 for MacOS and Windows, but all Python version for Ubuntu. matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
exclude:
# only test Python 3.9 and 3.13 for MacOS and Windows
- os: macos-latest
python-version: ['3.9', '3.10', '3.11', '3.12']
- os: windows-latest
python-version: ['3.9', '3.10', '3.11', '3.12'] |
Closing this one in favor of #381 |
This would make future releases formally installable in a Python 3.13 environment.
Summary by Sourcery
Add Python 3.13 to the CI test matrix and project metadata to enable compatibility with Python 3.13
Enhancements:
CI:
Documentation: