Skip to content

Use Python 3.13 as newest Python version for pytest workflow #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented May 30, 2025

This would make future releases formally installable in a Python 3.13 environment.

Summary by Sourcery

Add Python 3.13 to the CI test matrix and project metadata to enable compatibility with Python 3.13

Enhancements:

  • Support Python 3.13 as a runtime environment

CI:

  • Test against Python 3.13 in the GitHub Actions pytest workflow

Documentation:

  • Include "Programming Language :: Python :: 3.13" in the package classifiers in pyproject.toml

@tovrstra tovrstra requested a review from FanwangM May 30, 2025 06:22
Copy link
Contributor

sourcery-ai bot commented May 30, 2025

Reviewer's Guide

This PR extends CI testing and project metadata to formally support Python 3.13 by updating the GitHub Actions workflow matrix and adding the new classifier.

File-Level Changes

Change Details Files
Include Python 3.13 in the CI test matrix
  • Replaced '3.12' with '3.13' in the pytest GitHub Actions matrix
  • Ensured the workflow still covers 3.9 alongside the new version
.github/workflows/pytest.yaml
Add Python 3.13 classifier in project metadata
  • Appended "Programming Language :: Python :: 3.13" to the classifiers list
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

deepsource-io bot commented May 30, 2025

Here's the code health analysis summary for commits ab01d84..feeaad9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@FanwangM FanwangM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great to me. One minor point: do we want to test against all Python versions for Python >= 3.9 instead of ['3.9', '3.13'] ? This might lead to longer test durations, but more structured testing guarantees our package functions effectively across all versions.

@tovrstra

@tovrstra
Copy link
Member Author

I think it makes sense to test on more Python version, but does indeed become slower. We might also consider testing on all Python version on Linux only. Similarly, we can test on all OSes with just one Python version? (Testing is notably slower on macOS virtual machines.)

@FanwangM
Copy link
Contributor

This proposal looks great. How about this? We only test Python 3.13 for MacOS and Windows, but all Python version for Ubuntu.

@tovrstra

      matrix:
        os: [ubuntu-latest, macos-latest, windows-latest]
        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
        exclude:
          # only test Python 3.9 and 3.13 for MacOS and Windows
          - os: macos-latest
            python-version: ['3.9', '3.10', '3.11', '3.12']
          - os: windows-latest
            python-version: ['3.9', '3.10', '3.11', '3.12']

@tovrstra
Copy link
Member Author

tovrstra commented Jun 2, 2025

Closing this one in favor of #381

@tovrstra tovrstra closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants