Fix ESAPI.flush_handle #635
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text Replace TPM2_HT with TPM2_HR so that the correct bits are checked to deteremine if an object handle is transient. Signed-off-by: pbartell <[email protected]>
Signed-off-by: pbartell <[email protected]>
paulbartell
force-pushed
the
fix-flush-handle
branch
from
4cb0130 to
89f23b2
Compare
|
Fix the style check, the other issues is due to changes in upstream, I'll fix them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the flush_handle function of ESAPI.py is incorrect.
Rather than comparing handles against the 24-bit left shifted TPM2_HT type, It uses the TPM2_HR type. Thus all calls to flush_handle prior to this change set never actually flushed the given handle.