files_load_unique_data: fix unique data copy to ecc point #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split of unique data into x and y components of ecc point currently fumbles the indexes leading to incomplete copy. Using "IAK" (size=3) as input, this leads to: > x.size = (unique_size / 2) = 1 > x.buffer = unique_size[0,1[ = ['I'] > y.size = (unique_size / 2) + (unique_size % 2) = 2 > y.buffer = unique_size[1,2[ + 0 = ['A', 0] Change copy bounds to copy "bigger" first half in x and remainder in y to reach a more reasonable result: > x.size = (unique_size / 2) + (unique_size % 2) = 2 > x.buffer = unique_size[0,2[ = ['I', 'A'] > y.size = (unique_size / 2) + (unique_size % 2) = 2 > y.buffer = unique_size[2,3[ + 0 = ['K', 0] Signed-off-by: Julien Gomes <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 74.38% 74.38% -0.01%
==========================================
Files 173 173
Lines 23673 23672 -1
==========================================
- Hits 17610 17609 -1
Misses 6063 6063 ☔ View full report in Codecov by Sentry. |
|
I think this makes a lot of sense. BUT, this looks like a change in behavior, i.e. different key derivation and such. @williamcroberts Your thoughts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of unique data into x and y components of ecc point currently fumbles the indexes leading to incomplete copy.
Using "IAK" (size=3) as input, this leads to:
Change copy bounds to copy "bigger" first half in x and remainder in y to reach a more reasonable result: