Extend key -read and -write functions #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an existing key or the new key is not intended to be stored in a file, the current implementation requires the creation of temporary files with all its odds (cleanup, symlink attack, mktemp) This change allows to provide the key in many different ways: A filename of "-" translates to <stdin> for reading and <stdout> for writing. If the file named by "filename" does not exist, check whether it contains a "-----BEGIN" and try interpreting the filename itself as key. Extend documentation in README.md Signed-off-by: Christian Hohnstaedt <[email protected]>
AndreasFuchsTPM
approved these changes
Mar 19, 2024
|
@chris2511 This is really useful and we were also thinking in the same way. I was using /tmp folder for key creation while using tpm2tss-genkey but our static code analyzer Sonar was warning about this security hotspot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an existing key or the new key is not intended to be stored in a file, the current implementation requires the creation of temporary files with all its odds (cleanup, symlink attack, mktemp)
This change allows to provide the key in many different ways:
A filename of "-" translates to for reading and for writing.
If the file named by "filename" does not exist,
check whether it contains a "-----BEGIN" and try interpreting the filename itself as key.
Extend documentation in README.md