Skip to content

py-call-osafterfork isn't needed in python 3.13+ #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
duzumaki wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −7
Draft

py-call-osafterfork isn't needed in python 3.13+ #2736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions plugins/python/python_plugin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,13 +460,18 @@ void uwsgi_python_post_fork() {

// reset python signal flags so child processes can trap signals
// Necessary if uwsgi fork hooks not called to update interpreter state
if (!up.call_uwsgi_fork_hooks && up.call_osafterfork) {
#ifdef HAS_NOT_PYOS_FORK_STABLE_API
PyOS_AfterFork();
#else
PyOS_AfterFork_Child();
#endif
}
#if PY_VERSION_HEX < 0x030D0000
Copy link
Collaborator

@xrmx xrmx Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move preprocessor directives to column 0, also you can use #ifdef UWSGI_PY313

if (!up.call_uwsgi_fork_hooks && up.call_osafterfork) {
// before python 3.7
#ifdef HAS_NOT_PYOS_FORK_STABLE_API
PyOS_AfterFork();
Copy link
Collaborator

@xrmx xrmx Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's one tab too much


// python 3.7 - 3.12
#else
PyOS_AfterFork_Child();
#endif
}
#endif

uwsgi_python_reset_random_seed();

Expand Down