Fix for gracefully_kill_them_all() which broke setups using fifo-base… #2740
+44
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wynnw
force-pushed
the
bugfix/gracefully-kill-them-all-nohang
branch
from
1fa601b to
b2d2bf9
Compare
xrmx
reviewed
Oct 7, 2025
…d master graceful reload - Instead of doing a blocking waitpid call, use WNOHANG calls to avoid breaking existing child process signal handling which was part of the master fork/exit cleanup that allowed FIFO-based zero downtime reloads to happen. This will also allow the fix to continue on as this code will block until all the workers have exited.
wynnw
force-pushed
the
bugfix/gracefully-kill-them-all-nohang
branch
from
b2d2bf9 to
79f00d1
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2722 which is a critical bug blocking existing users from upgrading. It keeps the same logic as the original fix in #2656 (included in the 2.0.27 release) by blocking the gracefully_kill_them_all() function from finishing until all the child workers exit. BUT, it uses the WNOHANG approach which seems to allow existing signal handler logic to do the needed cleanup for the old master process to exit cleanly.
Please consider this - thanks!