Skip to content

A bit of polish on our nightly report #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 5, 2025
Merged

A bit of polish on our nightly report #97

merged 11 commits into from
May 5, 2025

Conversation

jonkeane
Copy link
Collaborator

@jonkeane jonkeane commented May 3, 2025

A few cleanups:

  • Cleaned up our crossbow nightly report to be tabbed
    Screenshot 2025-05-02 at 23 00 14

  • fixed machine names for our performance reports

  • updating renv locks to actually install binaries

  • cleaner names for GHA jobs

@assignUser @raulcd Do either of you know how the performance report gets triggered in our release process? I saw runs like https://github.com/ursacomputing/crossbow/actions/runs/14333506941 but I don't quite know what triggers that?

cc @boshek

@jonkeane jonkeane requested a review from raulcd May 3, 2025 04:04
@jonkeane jonkeane requested a review from assignUser May 3, 2025 04:07
@assignUser
Copy link
Contributor

Oh this is great, thank you!

We trigger the workflow that generates the report manually from the actions tab with refs for base and contender that have existing conbench runs. I manually triggered a benchmark on the rc branch for it but ran into the issue with the machine names.

@jonkeane
Copy link
Collaborator Author

jonkeane commented May 3, 2025

We trigger the workflow that generates the report manually from the actions tab with refs for base and contender that have existing conbench runs. I manually triggered a benchmark on the rc branch for it but ran into the issue with the machine names.

Ha! I just assumed this was all automatic. Is there a (more) automatic way of getting the baseline and contender shas? I actually found that was one of the most annoying parts of getting this setup to run again locally. Also, did I miss a reference to it in the release checklist/guide? I went looking for it but couldn't find anything. It's not a huge deal but would be good if that was discoverable :)

@assignUser
Copy link
Contributor

Agreed on both points, it is quite annoying and should be made easier but at the minimum be added to the release guide! I'll open an Issue.

@assignUser
Copy link
Contributor

apache/arrow#46323

@jonkeane
Copy link
Collaborator Author

jonkeane commented May 5, 2025

Thanks 🙏

@jonkeane jonkeane merged commit 2738e32 into main May 5, 2025
3 checks passed
@jonkeane jonkeane deleted the report_polish branch May 5, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants