Replace deprecated golang/x/crypto/openpgp #56
Merged
NamelessOne91 merged 3 commits intouyuni-project:masterfrom Mar 17, 2025
Merged
Replace deprecated golang/x/crypto/openpgp #56NamelessOne91 merged 3 commits intouyuni-project:masterfrom
NamelessOne91 merged 3 commits intouyuni-project:masterfrom
Conversation
Bischoff
approved these changes
Mar 17, 2025
Bischoff
left a comment
Bischoff
left a comment
There was a problem hiding this comment.
I was not able to check all details of vendoring 🧌
ktsamis
approved these changes
Mar 17, 2025
ktsamis
left a comment
ktsamis
left a comment
There was a problem hiding this comment.
I don't see anything obvious but I didn't check authors contributors etc, these docs. And for the code I'm not sure I'm qualified but nothing looks completely wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/SUSE/spacewalk/issues/26645
As of golang/go#44226 openpgp support has been dropped from Go's standard and experimental libraries.
It would be better to replace it with something still maintained and more up-to-date, even though we have to deal with RPMs signed with OpenPGP V3 signatures (old standard).
To that end: