Skip to content

Replace deprecated golang/x/crypto/openpgp #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NamelessOne91
Copy link
Contributor

@NamelessOne91 NamelessOne91 commented Mar 12, 2025

Related to: https://github.com/SUSE/spacewalk/issues/26645

As of golang/go#44226 openpgp support has been dropped from Go's standard and experimental libraries.

It would be better to replace it with something still maintained and more up-to-date, even though we have to deal with RPMs signed with OpenPGP V3 signatures (old standard).

To that end:

  1. github.com/ProtonMail/go-crypto is a fork and drop-in replacement for golang/x/crypto, with openpgp support. However, they made quite a few changes and eventually dropped V3 signatures compatibility.
  2. github.com/pgpkeys-eu/go-crypto is a soft fork of the above which provides also V3 signatures compatibility

@NamelessOne91 NamelessOne91 self-assigned this Mar 12, 2025
@Bischoff Bischoff self-requested a review March 17, 2025 15:20
Copy link

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to check all details of vendoring 🧌

Copy link

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything obvious but I didn't check authors contributors etc, these docs. And for the code I'm not sure I'm qualified but nothing looks completely wrong

@NamelessOne91 NamelessOne91 merged commit 453d6a0 into uyuni-project:master Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants