Escape pkg names in URLs #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamelessOne91
force-pushed
the
url_escaping
branch
2 times, most recently
from
1574071 to
32b96fb
Compare
NamelessOne91
force-pushed
the
url_escaping
branch
from
32b96fb to
5d50bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/SUSE/spacewalk/issues/26920
Some packages have + characters in their name, think of pkgs which explicitly state c++ as an example.
Although + should be a valid character in URL Paths, some middleware software are not 100% compliant with the standard and interpret it as the encoding for " " (an empty space), as if dealing with queries.
They expect + characters to be encoded to %2B, which is actually the encoding needed for URL Queries.