remove /etc/systemd/system/uyuni-server.service.d/Service.conf during uninstallation #293
Conversation
shared/podman/systemd.go
Outdated
| @@ -39,16 +39,23 @@ func GetServicePath(name string) string { | |||
| return path.Join(servicesPath, name+".service") | |||
| } | |||
|
|
|||
| // GetServiceConfPath return the path for Service.conf file. | |||
| func GetServiceConfPath(name string) string { | |||
| return path.Join(servicesPath, name+".service.d", "Service.conf") | |||
There was a problem hiding this comment.
It is the only file we want to remove in that folder? Shouldn't we remove all user-added files there too?
There was a problem hiding this comment.
For sure the folder should be removed if there're no files, I'm going to add this change.
I'm not sure if we should remove the user-added file: I think we should have the same behaviour of command like zypper uninstall and I think the user file are not deleted by that command.
What do you think?
There was a problem hiding this comment.
We can leave them, but a new install after would be polluted by those... not sure what's best.
|
mbussolotto
force-pushed
the
remove_service_conf
branch
from
0338d9e to
7a9261a
Compare
|
@cbosdo Check if this might be a good option:
|
What does this PR change?
See the title
Test coverage
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!